Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_connect_bot_association - add new resource #21097

Merged
merged 42 commits into from
Dec 10, 2021
Merged

r/aws_connect_bot_association - add new resource #21097

merged 42 commits into from
Dec 10, 2021

Conversation

thornleyk
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21044

Release note for CHANGELOG:

resource_aws_connect_bot_association - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsConnectBotAssociationDataSource_basic'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsConnectBotAssociationDataSource_basic -timeout 180m
=== RUN   TestAccAwsConnectBotAssociationDataSource_basic
--- PASS: TestAccAwsConnectBotAssociationDataSource_basic (64.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	67.325s
...

$ make testacc TESTARGS='-run=TestAccAwsConnectBotAssociation_serial'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsConnectBotAssociation_serial -timeout 180m
=== RUN   TestAccAwsConnectBotAssociation_serial
=== RUN   TestAccAwsConnectBotAssociation_serial/basic
=== PAUSE TestAccAwsConnectBotAssociation_serial/basic
=== RUN   TestAccAwsConnectBotAssociation_serial/disappears
=== PAUSE TestAccAwsConnectBotAssociation_serial/disappears
=== CONT  TestAccAwsConnectBotAssociation_serial/basic
=== CONT  TestAccAwsConnectBotAssociation_serial/disappears
--- PASS: TestAccAwsConnectBotAssociation_serial (0.00s)
    --- PASS: TestAccAwsConnectBotAssociation_serial/disappears (64.75s)
    --- PASS: TestAccAwsConnectBotAssociation_serial/basic (68.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.950s

thornleyk and others added 25 commits September 24, 2021 21:30
@thornleyk
feat: migrate old resources
cb3834f
@thornleyk
feat: add data source
22b0d93
@AdamTylerLynch
Moving CONST to waiter.
7d67769
@AdamTylerLynch
Moving utility function below CRUD
c20a22e
@AdamTylerLynch
Migrated LexAssociationByName to finder.
badded9
@AdamTylerLynch
cleaning up formatting
2e52045
@AdamTylerLynch
migrating AccTests to use finder
d653270
@AdamTylerLynch
adjusting AccTest format to pass linters.
e750f10
@AdamTylerLynch
updating Region as required, updated AccTest
3ed8658
@AdamTylerLynch
updated AccTest with region
411e81f
@AdamTylerLynch
Implement finder and add region to the DataSource test.
e3fc2e8
@AdamTylerLynch
updated Lex Bot docs and req field formats.
be4ef06
@AdamTylerLynch
added exteded sample into the docs.
c929a97
@AdamTylerLynch
refactor attribute names to match API input.
cdc55bf
@AdamTylerLynch
fixing AccTests
2bdee0d
@AdamTylerLynch
fixing AccTests
0ff052d
@thornleyk
fix: add retry on lex building state response
a397a79
@thornleyk
chore: refactor connect bot association
7b4d803
@thornleyk
chore: merge upstream
b7e3dac
@thornleyk
chore: merge provider
f9f69b1
@thornleyk
Merge branch 'main' of https://github.com/hashicorp/terraform-provide…
fa1ac5e 
…r-aws into hashicorp-main
@thornleyk
Merge branch 'hashicorp-main' into f-aws_connect_bot_association
480cd26
@thornleyk
chore: revert change
6367e45
@thornleyk
chore: revert change
dfdea2a
@thornleyk
chore: revert
8d90a00
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 30, 2021
@AdamTylerLynch
Copy link
Collaborator

LGTM.

make testacc TESTARGS='-run=TestAccBotAssociation' PKG_NAME=internal/service/connect ACCTEST PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccBotAssociation -timeout 180m
=== RUN TestAccBotAssociationDataSource_basic
--- PASS: TestAccBotAssociationDataSource_basic (134.60s)
=== RUN TestAccBotAssociation_serial
=== RUN TestAccBotAssociation_serial/disappears
=== PAUSE TestAccBotAssociation_serial/disappears
=== RUN TestAccBotAssociation_serial/basic
=== PAUSE TestAccBotAssociation_serial/basic
=== CONT TestAccBotAssociation_serial/disappears
=== CONT TestAccBotAssociation_serial/basic
--- PASS: TestAccBotAssociation_serial (0.00s)
--- PASS: TestAccBotAssociation_serial/disappears (88.98s)
--- PASS: TestAccBotAssociation_serial/basic (96.45s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 234.090s

@AdamTylerLynch
Copy link
Collaborator

LGTM

make testacc TESTARGS='-run=TestAccBotAssociation' PKG_NAME=internal/service/connect ACCTEST PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20 -run=TestAccBotAssociation -timeout 180m
=== RUN TestAccBotAssociationDataSource_basic
--- PASS: TestAccBotAssociationDataSource_basic (86.77s)
=== RUN TestAccBotAssociation_serial
=== RUN TestAccBotAssociation_serial/basic
=== PAUSE TestAccBotAssociation_serial/basic
=== RUN TestAccBotAssociation_serial/disappears
=== PAUSE TestAccBotAssociation_serial/disappears
=== CONT TestAccBotAssociation_serial/basic
=== CONT TestAccBotAssociation_serial/disappears
--- PASS: TestAccBotAssociation_serial (0.00s)
--- PASS: TestAccBotAssociation_serial/disappears (85.21s)
--- PASS: TestAccBotAssociation_serial/basic (89.14s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/connect 177.461s

@AdamTylerLynch
Copy link
Collaborator

Review Requested.

@anGie44 anGie44 added new-resource Introduces a new resource. new-data-source Introduces a new data source. labels Dec 8, 2021
@anGie44 anGie44 self-assigned this Dec 9, 2021
@anGie44 anGie44 force-pushed the f-aws_connect_bot_association branch from a3d098c to a6c0124 Compare December 9, 2021 21:52
@anGie44
Copy link
Contributor

anGie44 commented Dec 9, 2021

Output of acceptance tests after updating the schema to align with AWS API (still limited to Lex V1 usage):

--- PASS: TestAccConnectBotAssociationDataSource_basic (102.72s)
--- PASS: TestAccConnectBotAssociation_serial (167.34s)
    --- PASS: TestAccConnectBotAssociation_serial/disappears (82.86s)
    --- PASS: TestAccConnectBotAssociation_serial/basic (84.47s)

@anGie44 anGie44 added this to the v3.70.0 milestone Dec 10, 2021
anGie44
anGie44 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thornleyk and @AdamTylerLynch for working on this feature! Overall, looked great 👍 To align with the Connect API methods used, i've updated the schema to reflect the Lex V1 input parameters, while leaving the possibility for V2 compatibility in a future enhancement request. A couple cosmetic fixes to the tests, otherwise this looks ready to go 🚀

@anGie44 anGie44 merged commit 44596d9 into hashicorp:main Dec 10, 2021
@abebars abebars deleted the f-aws_connect_bot_association branch December 13, 2021 16:14
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

@YakDriver YakDriver Awaiting requested review from YakDriver

@breathingdust breathingdust Awaiting requested review from breathingdust

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/connect Issues and PRs that pertain to the connect service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.70.0
Development

Successfully merging this pull request may close these issues.

Add new resource/data_source for aws_connect_bot_association
5 participants
@thornleyk @AdamTylerLynch @zhelding @anGie44 @abebars